Ticket #87 (closed defect: fixed)

Opened 11 months ago

Last modified 3 months ago

Does not build with gcc-4.3

Reported by: belegdol Owned by: daelstorm
Priority: major Milestone:
Component: museek_general Version: 0.1.13
Keywords: Cc:

Description

This will be required for inclusion in Fedora 9. Build log is here: http://sunsite.mff.cuni.cz/rawhide20071220-gcc43/header-dep/museek+-0.1.13-1.fc8.log The error is described by the gcc maintainer as the following: libstdc++ header dependencies have been streamlined, reducing unnecessary includes and pre-processed bloat. The STL headers have been cleaned up, so that the headers don't drag in unnecessary dependencies which aren't requested by the standard. E.g. <string> no longer includes <cstdlib>, etc. Most of these bugs will be fixed just by including the proper headers, <cstdlib>, <cstring>, <cstdio> are the most common ones

Cheers.

Attachments

museek+-gcc43.patch (289 bytes) - added by belegdol 3 months ago.
New patch required to build newnet2 branch

Change History

Changed 10 months ago by belegdol

Please review this patch, as my coding skills are negligible. Especially, I am not sure if the duplicate function parameters fix is correct.

Changed 10 months ago by belegdol

  • status changed from new to closed
  • resolution set to fixed

Patch has been committed to SVN trunk. Closing.

Changed 3 months ago by belegdol

New patch required to build newnet2 branch

Changed 3 months ago by belegdol

  • status changed from closed to reopened
  • resolution fixed deleted

The newnet2 branch needs one more include to build with gcc 4.3.x correctly. lbponey, I'm not committing this myself in case you have some uncommitted changes. Cheers.

Changed 3 months ago by lbponey

  • status changed from reopened to closed
  • resolution set to fixed

Thanks belegdol! I've committed it. Tell me if there are other errors or warnings.

Add/Change #87 (Does not build with gcc-4.3)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.