Ticket #89 (new defect)
Opened 7 months ago
Download Directory picks the wrong dir to download
| Reported by: | imslushie@… | Owned by: | daelstorm |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | mucous | Version: | 0.1.12 |
| Keywords: | browse download directory | Cc: |
Description
While browsing a user, selecting Download Dir in the context menu for the folder list will attempt to download the parent directory when there are no files (only subfolders) beneath the selected folder.
This is a bug at least in mucous 0.9.12 (the version provided by my OS), MucousPopup.py's ExecuteBrowse method caused by self.mucous.Transfers.FolderDownload receiving a folder path that has no basename, eg. top\parent\child instead of top\parent\child\. The bug doesn't surface if the folder has any files within it, because then {self.mucous.BrowseShares.CurrentFile() chooses a filename, which can be stripped.
The net effect of this bug is that I try to download all albums by a single artist and end up trying to download all folders under the top level of the hierarchy -- that is, every shared file.
I have include a patch against my version of MucousPopup.py, there is a description in the comments that could be used for patching other versions as well. It really is a simple fix.
